swarm/src/lib: Rework connection exports #2525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to unblock @dignifiedquire, i.e. to expose
ConnectionLimits
. My bad, bug introduced with #2492.I am surprised that the compiler didn't catch
ConnectionLimits
not being exposed, given that it is used in the publicSwarmBuilder
methodconnection_limits
.For a follow up pull request:
I am not happy with how we do exports in
libp2p-swarm
today, mostly as it does not seem to be consistent and thus not intuitive.behaviour
andprotocols_handler
as a exports grouping mechanism. Ideally with Adopt naming conventions that don't repeat names #2174, i.e. exposinglibp2p_swarm::behaviour::Action
and notlibp2p_swarm::behaviour::NetworkBehaviourAction
.Pool
should never be exposed) as well as preventing to forget exposing a publicly used type (e.g.ConnectionLimits
).Anyone has opinions / suggestions on the above?